Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up docstrings #5334

Merged
merged 5 commits into from Dec 9, 2022
Merged

Clean up docstrings #5334

merged 5 commits into from Dec 9, 2022

Conversation

stevhliu
Copy link
Member

@stevhliu stevhliu commented Dec 5, 2022

As raised by @polinaeterna in #5324, some of the docstrings are a bit of a mess because it has both Markdown and Sphinx syntax. This PR fixes the docstring for DatasetBuilder.

I'll start working on cleaning up the rest of the docstrings and removing the old Sphinx syntax (let me know if you prefer one big PR with all the cleaned changes or multiple smaller ones)! 馃Ъ

@stevhliu stevhliu added the documentation Improvements or additions to documentation label Dec 5, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 5, 2022

The documentation is not available anymore as the PR was closed or merged.

@lhoestq
Copy link
Member

lhoestq commented Dec 7, 2022

Thanks ! Let us know if we can help :)

Small pref for having multiple PRs

@stevhliu stevhliu marked this pull request as ready for review December 7, 2022 18:56
@stevhliu
Copy link
Member Author

stevhliu commented Dec 7, 2022

Awesome, thanks! Sorry this one is a little big, I'll open some smaller ones next :)

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good !

src/datasets/download/download_manager.py Outdated Show resolved Hide resolved
Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
@stevhliu stevhliu merged commit 6338ded into huggingface:main Dec 9, 2022
@stevhliu stevhliu deleted the clean-docstring branch December 9, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants