Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tasks.json #5335

Closed
wants to merge 1 commit into from
Closed

Update tasks.json #5335

wants to merge 1 commit into from

Conversation

sayakpaul
Copy link
Member

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 6, 2022

The documentation is not available anymore as the PR was closed or merged.

@lhoestq
Copy link
Member

lhoestq commented Dec 6, 2022

I think the only place where we need to add it is here https://github.com/huggingface/hub-docs/blob/main/js/src/lib/interfaces/Types.ts

And I think we can remove tasks.json completely from this repo

@osanseviero
Copy link
Member

Isn't tasks.json used anymore in this repo?

@sayakpaul
Copy link
Member Author

I think the only place where we need to add it is here https://github.com/huggingface/hub-docs/blob/main/js/src/lib/interfaces/Types.ts

And I think we can remove tasks.json completely from this repo

What about the warning I mentioned in #5255 (comment)? Also, the depth estimation entry is already present in https://github.com/huggingface/hub-docs/blob/main/js/src/lib/interfaces/Types.ts.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sayakpaul,

Please note that depth-estimation is defined as a possible value for class_categories, not for class_ids. You should set instead:

task_categories:
- depth-estimation
task_ids: []

We no longer use tasks.json file.

@sayakpaul
Copy link
Member Author

sayakpaul commented Dec 7, 2022

The update is based on what I received in the output of the export job (c.f. #5255 (comment)).

Edit: Oh, are you referring to the dataset card of NYU Depth V2?

@albertvillanova
Copy link
Member

Yes, my suggestion was for the dataset card: you got the error message because you tried to set depth-estimation in class_ids instead of class_categories.

@lhoestq
Copy link
Member

lhoestq commented Dec 7, 2022

What about the warning I mentioned in #5255 (comment)? Also, the depth estimation entry is already present in https://github.com/huggingface/hub-docs/blob/main/js/src/lib/interfaces/Types.ts.

if you place it in task_categories you should be good :)

@julien-c
Copy link
Member

julien-c commented Dec 7, 2022

yes i would suggest rm'ing tasks.json here for clarity

@sayakpaul
Copy link
Member Author

Closing it.

@sayakpaul sayakpaul closed this Dec 7, 2022
@lhoestq
Copy link
Member

lhoestq commented Dec 7, 2022

It's not clear if we can remove it btw, since old versions of evaluate rely on it (see huggingface/evaluate#309)

cc @lvwerra

@lhoestq lhoestq mentioned this pull request Dec 8, 2022
@lhoestq
Copy link
Member

lhoestq commented Dec 8, 2022

Actually it can be removed without incidence in old versions of evaluate since we kept an hardcoded known_task_ids that is marked "DEPRECATED"

@albertvillanova albertvillanova deleted the update/tasks branch September 24, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants