Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify skipping #5373

Merged
merged 1 commit into from Dec 18, 2022
Merged

Simplify skipping #5373

merged 1 commit into from Dec 18, 2022

Conversation

Muennighoff
Copy link
Contributor

@Muennighoff Muennighoff commented Dec 17, 2022

Was hoping to find a way to speed up the skipping as I'm running into bottlenecks skipping 100M examples on C4 (it takes 12 hours to skip), but didn't find anything better than this small change :(

Maybe there's a way to directly skip whole shards to speed it up? 馃

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 17, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Yea we don't know the shard sizes so we don't know how many shards to skip

@Muennighoff Muennighoff merged commit 4403d06 into main Dec 18, 2022
@Muennighoff Muennighoff deleted the simplify-skip branch December 18, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants