Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (#619) MLQA features names #627

Merged
merged 1 commit into from
Sep 16, 2020
Merged

fix (#619) MLQA features names #627

merged 1 commit into from
Sep 16, 2020

Conversation

M-Salti
Copy link
Contributor

@M-Salti M-Salti commented Sep 14, 2020

Fixed the features names as suggested in (#619) in the _generate_examples and _info methods in the MLQA loading script and also changed the names in the dataset_infos.json file.

@M-Salti M-Salti changed the title fix (#619) fix (#619) MLQA features names Sep 14, 2020
thomwolf
thomwolf approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@thomwolf thomwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thomwolf thomwolf merged commit f3cd978 into huggingface:master Sep 16, 2020
JetRunner pushed a commit that referenced this pull request Sep 17, 2020
@M-Salti @JetRunner
fix (#619) (#627)
44f1480
@M-Salti M-Salti deleted the fix-mlqa-features-names branch November 2, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomwolf thomwolf thomwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@M-Salti @thomwolf