New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make shuffle compatible with temp_seed #640

Merged

lhoestq merged 1 commit into master from make-shuffle-compatible-with-temp_seed

Sep 18, 2020

Member

lhoestq commented Sep 18, 2020

This code used to return different dataset at each run

import dataset as ds

dataset = ...

with ds.temp_seed(42):
    shuffled = dataset.shuffle()

Now it returns the same one since the seed is set


          make shuffle compatible with temp_seed

abd4245

thomwolf approved these changes

View reviewed changes

Member

thomwolf left a comment

Nice!

lhoestq merged commit 116bc31 into master

lhoestq deleted the make-shuffle-compatible-with-temp_seed branch

September 18, 2020 11:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment