Better windows support #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomwolf
reviewed
Sep 18, 2020
lhoestq
force-pushed
the
fix-tests-on-windows
branch
from
58f4842
to
8eaadf6
Compare
|
This PR is ready :) Some tests |
thomwolf
approved these changes
Sep 25, 2020
| @@ -26,6 +30,41 @@ jobs: | |||
| - run: pip install pyarrow==1.0.0 | |||
| - run: HF_SCRIPTS_VERSION=master python -m pytest -sv ./tests/ | |||
|
|
|||
|
|
|||
| run_dataset_script_tests_pyarrow_0p17_WIN: | |||
This was referenced Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few differences in the behavior of python and pyarrow on windows.
For example there are restrictions when accessing/deleting files that are open
Fix #590