Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pyarrow LargeListType #6835

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Modexus
Copy link
Contributor

@Modexus Modexus commented Apr 24, 2024

Fixes #6834

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Modexus
Copy link
Contributor Author

Modexus commented Apr 24, 2024

Fixed the conversion from pyarrow to python Sequence features.

There is still an issue that if features are passed the Sequence always forces conversion to ListArray.
This probably causes issues if the LargeListArray is actually needed.

There doesn't seem to be a great solution since this list is created solely on the schema for Sequence.
One solution would be to always use LargeListArray instead.

@Modexus Modexus changed the title Fix LargeListType not supported #6834 LargeListType support #6834 Apr 24, 2024
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Modexus.

Sorry for the late review.

In relation with the conversion of Sequence, we had a discussion time ago, and we proposed to add a parameter to Sequence to specify to convert it to whether regular list or large list. See comments:

Would you be interested in implementing this in your PR?

@albertvillanova albertvillanova changed the title LargeListType support #6834 Sypport pyarrow LargeListType Jun 21, 2024
@albertvillanova albertvillanova changed the title Sypport pyarrow LargeListType Support pyarrow LargeListType Jun 21, 2024
@albertvillanova
Copy link
Member

I am retaking this PR because we would like to have this feature implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

largelisttype not supported (.from_polars())
3 participants