Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom split names in text dataset #776

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Oct 29, 2020

The text dataset used to return only splits like train, test and validation. Other splits were ignored.
Now any split name is allowed.

I did the same for json, pandas and csv

Fix #735

@lhoestq lhoestq merged commit 6fec6b1 into master Oct 30, 2020
@lhoestq lhoestq deleted the allow-custom-split-names-in-text-dataset branch October 30, 2020 13:23
@BramVanroy
Copy link
Contributor

Awesome! This will make the behaviour much more intuitive for some non-standard code.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw error when an unexpected key is used in data_files
2 participants