Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit3 error message when pushing model to hugging face #539

Closed
foye501 opened this issue Jun 12, 2024 · 11 comments
Closed

unit3 error message when pushing model to hugging face #539

foye501 opened this issue Jun 12, 2024 · 11 comments

Comments

@foye501
Copy link

foye501 commented Jun 12, 2024

Describe the bug

in unit3 I run into error message when pushing model to hugging face?

Screenshot 2024-06-12 at 16 05 12

A clear and concise description of what the bug is.
Please share your notebook link so that we can reproduce the error

Material

  • Did you use Google Colab?
    yes

If not:

  • Your Operating system (OS)
  • Version of your OS
@foye501 foye501 changed the title unit3 unit3 error message when pushing model to hugging face Jun 12, 2024
@simoninithomas
Copy link
Member

Hey there 👋

Did you tried to just run solutions of the notebook to test if it works correctly?

If yes, please provide your notebook link so that I can check what's the problem

@foye501
Copy link
Author

foye501 commented Jun 13, 2024

Hey there 👋

Did you tried to just run solutions of the notebook to test if it works correctly?

If yes, please provide your notebook link so that I can check what's the problem

Yes, I have just try the solution except that of pushing model. It failed again, I guess maybe the version of some package doesn't right. Thank you for your help.

this is my notebook https://colab.research.google.com/github/huggingface/deep-rl-class/blob/main/notebooks/unit3/unit3.ipynb#scrollTo=co5um_KeKbBJ

@simoninithomas
Copy link
Member

So I tested it and it work correctly:

  1. Did you changed orga here with your username (beware that if you have MAJ it takes into account, for instance my username is ThomasSimonini not thomassimonini).

!python -m rl_zoo3.push_to_hub --algo dqn --env SpaceInvadersNoFrameskip-v4 --repo-name dqn-SpaceInvadersNoFrameskip-v4vvvv -orga ThomasSimonini -f logs/

  1. When you put your write token above did it says your token was correct?

@simoninithomas
Copy link
Member

Screenshot 2024-06-13 at 10 30 25

@foye501
Copy link
Author

foye501 commented Jun 17, 2024

So I tested it and it work correctly:

  1. Did you changed orga here with your username (beware that if you have MAJ it takes into account, for instance my username is ThomasSimonini not thomassimonini).

!python -m rl_zoo3.push_to_hub --algo dqn --env SpaceInvadersNoFrameskip-v4 --repo-name dqn-SpaceInvadersNoFrameskip-v4vvvv -orga ThomasSimonini -f logs/

  1. When you put your write token above did it says your token was correct?

Thank you, I tried it again. I am sure that I loged in using the tokens. but I still face the keyerror, this is my copy of notebook.
https://colab.research.google.com/drive/13R97v7Xcyyn-qFao4iyuC1ywgBzvDngE#scrollTo=2RVEdunPHs8B

@foye501
Copy link
Author

foye501 commented Jun 17, 2024

It creates a empty folder in my huggingface ,
https://huggingface.co/foye501/SpaceInvadersNoFrameskipv4

@simoninithomas
Copy link
Member

I don't have access to your notebook I just asked access.

@foye501
Copy link
Author

foye501 commented Jun 21, 2024

I don't have access to your notebook I just asked access.

Thank you

@simoninithomas
Copy link
Member

Hi, I tried from scratch it seems to work.
Are you sure you didn't missed a step:

  • Did you created dqn.yml?
  • Did your read the messages after the training? If it wasn't saved etc?

For me the best is take the notebook from scratch: a new version of the notebook.

@foye501
Copy link
Author

foye501 commented Jun 24, 2024

Thank you, I will try it again, Thank you.

Thank you, I will try it again, Thank you.

Hi, I tried from scratch it seems to work. Are you sure you didn't missed a step:

  • Did you created dqn.yml?
  • Did your read the messages after the training? If it wasn't saved etc?

For me the best is take the notebook from scratch: a new version of the notebook.

Thank you, I will try it again, Thank you.

@simoninithomas
Copy link
Member

I'm closing the issue for now, if there's still an issue after your new tries, please open a new one 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants