Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit2-push_to_hub #436

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fardinafdideh
Copy link
Contributor

Hi,

  • In unit2, in function "push_to_hub", the variable "env_id" has been used for the definition of variable "model_card". This variable, "env_id", hasn't been defined in the function "push_to_hub", and it uses a variable from outside of the function which is not necessarily the right value. It should be replaced with "model["env_id"]", i.e., "env_id" -> "model["env_id"]".

  • Model card is not updated when a new push is done, so I commented the following lines:

    readme = ""
    print(readme_path.exists())
    if readme_path.exists():
    with readme_path.open("r", encoding="utf8") as f:
    readme = f.read()
    else:
    readme = model_card

and added "readme = model_card", so that the model card is updated for each push.

@simoninithomas
Copy link
Member

Thanks for pointing this out I’m adding this for the december update

@simoninithomas simoninithomas mentioned this pull request Dec 12, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants