Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Add loading script #1174

Merged
merged 7 commits into from Nov 7, 2022
Merged

[Docs] Add loading script #1174

merged 7 commits into from Nov 7, 2022

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Nov 7, 2022 •
edited

Finally have a nice loading script

@patrickvonplaten patrickvonplaten changed the title add loading script [Docs] Add loading script Nov 7, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 7, 2022 •
edited

The documentation is not available anymore as the PR was closed or merged.

patil-suraj
patil-suraj approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool write-up ❤️ ! Just left nits.

And maybe also mention somewhere in the doc, that we recommend installing accelerate to improve loading speed.

docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
anton-l
anton-l approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@anton-l anton-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice guide, thank you Patrick!

@patrickvonplaten @anton-l @patil-suraj
Apply suggestions from code review
8d29dbc 
Co-authored-by: Anton Lozhkov <anton@huggingface.co>
Co-authored-by: Suraj Patil <surajp815@gmail.com>
pcuenca
pcuenca approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, useful and necessary! Thanks a lot for the effort!

docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
docs/source/using-diffusers/loading.mdx Outdated Show resolved Hide resolved
patrickvonplaten and others added 2 commits November 7, 2022 16:55
@patrickvonplaten @pcuenca
Apply suggestions from code review
9c9c1d7 
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
@patrickvonplaten
uP
1ae8a1e
pcuenca
pcuenca reviewed Nov 7, 2022
View reviewed changes
docs/source/using-diffusers/loading.mdx
```

Note how the above code snippet makes use of [`DiffusionPipeline.components`].

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@patrickvonplaten patrickvonplaten merged commit b500df1 into main Nov 7, 2022
@patrickvonplaten patrickvonplaten deleted the add_loading_script branch November 7, 2022 16:17
@patrickvonplaten patrickvonplaten mentioned this pull request Nov 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcuenca pcuenca pcuenca approved these changes

@anton-l anton-l anton-l approved these changes

@patil-suraj patil-suraj patil-suraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@patrickvonplaten @HuggingFaceDocBuilderDev @pcuenca @anton-l @patil-suraj