Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Loading] Make sure loading edge cases work #1192

Merged
merged 4 commits into from Nov 9, 2022
Merged

[Loading] Make sure loading edge cases work #1192

merged 4 commits into from Nov 9, 2022

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Nov 8, 2022 •
edited

Adds test to be sure edge loading cases work

Future TODOs:

@patrickvonplaten patrickvonplaten changed the title Make sure loading edge cases work [Loading] Make sure loading edge cases work Nov 8, 2022
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

anton-l
anton-l approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@anton-l anton-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for including the tests!

patil-suraj
patil-suraj approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@patrickvonplaten patrickvonplaten merged commit b93fe08 into main Nov 9, 2022
@patrickvonplaten patrickvonplaten deleted the make_sure_loading_edge_cases_work branch November 9, 2022 11:28
@skirsten skirsten mentioned this pull request Nov 16, 2022
Merged
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@patrickvonplaten
[Loading] Make sure loading edge cases work (huggingface#1192)
636ffd7 
* [Loading] Make edge cases work

* up

* finish

* up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-l anton-l anton-l approved these changes

@patil-suraj patil-suraj patil-suraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@patrickvonplaten @HuggingFaceDocBuilderDev @anton-l @patil-suraj