add v prediction #1386
Merged
add v prediction #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
patrickvonplaten
approved these changes
Nov 24, 2022
pcuenca
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
LGTM! Same comments as @patrickvonplaten regarding setting eps seemingly unnecessarily.
We'll need sample prediction type for Euler to support k-upscaler, but we can add it later.
This was referenced Nov 24, 2022
Closed
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
gabsoftware
added a commit
to gabsoftware/diffusers-nsfw
that referenced
this pull request
Nov 24, 2022
add v prediction (huggingface#1386)
sliard
pushed a commit
to sliard/diffusers
that referenced
this pull request
Dec 21, 2022
* add v prediction * adat euler for v pred * velocity -> v_prediction * simplify * fix naming * Update src/diffusers/schedulers/scheduling_euler_discrete.py Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * style Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* add v prediction * adat euler for v pred * velocity -> v_prediction * simplify * fix naming * Update src/diffusers/schedulers/scheduling_euler_discrete.py Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * style Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds v-prediction for DDIM and Euler scheduler.