Bump to 0.10.0.dev0 + deprecations #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-l
commented
Nov 30, 2022
Comment on lines
-669
to
-671
| def unwrap_model(model: torch.nn.Module) -> torch.nn.Module: | ||
| """ | ||
| Recursively unwraps a model from potential containers (as used in distributed training). |
There was a problem hiding this comment.
Not technically deprecated, but we've had this replaced by accelerate.unwrap_model a loooong time ago.
anton-l
commented
Nov 30, 2022
Comment on lines
73
to
-76
| "Please make sure to instantiate your scheduler with `prediction_type` instead. E.g. `scheduler =" | ||
| " DDPMScheduler.from_pretrained(<model_id>, prediction_type='epsilon')`." | ||
| ) | ||
| predict_epsilon = deprecate("predict_epsilon", "0.10.0", message, take_from=kwargs) |
There was a problem hiding this comment.
The predict_epsilon deprecation was only introduced 3 weeks ago, and we've had two rapid releases since then, so I'm keen on keeping it at least until next week.
There was a problem hiding this comment.
Agree - thanks for double-checking!
|
The documentation is not available anymore as the PR was closed or merged. |
patrickvonplaten
approved these changes
Nov 30, 2022
sliard
pushed a commit
to sliard/diffusers
that referenced
this pull request
Dec 21, 2022
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.