New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize 2nd order schedulers #1503
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
commented
Dec 1, 2022
patrickvonplaten
commented
Dec 1, 2022
@@ -131,7 +133,7 @@ def set_timesteps( | |||
self.init_noise_sigma = self.sigmas.max() | |||
|
|||
timesteps = torch.from_numpy(timesteps) | |||
timesteps = torch.cat([timesteps[:1], timesteps[1:].repeat_interleave(2), timesteps[-1:]]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was incorrect previously, but didn't change the output of the image. Can be removed so since it's an unnecessary extra step
The documentation is not available anymore as the PR was closed or merged. |
patrickvonplaten
changed the title
Finalizes 2nd order scheduler design
Finalize 2nd order schedulers
Dec 2, 2022
tcapelle
pushed a commit
to tcapelle/diffusers
that referenced
this pull request
Dec 12, 2022
* up * up * finish * finish * up * up * finish
sliard
pushed a commit
to sliard/diffusers
that referenced
this pull request
Dec 21, 2022
* up * up * finish * finish * up * up * finish
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* up * up * finish * finish * up * up * finish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects Heun scheduler (previously one unnecessary step was done).
Also adds two additional 2nd order schedulers:
Ran all schedulers for:
Results match k-diffusion implementation.