Add paint by example #1533
Merged
Add paint by example #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
commented
Dec 3, 2022
|
The documentation is not available anymore as the PR was closed or merged. |
…/diffusers into add_paint_by_example
patrickvonplaten
commented
Dec 6, 2022
tests/pipelines/stable_diffusion/test_stable_diffusion_inpaint.py
Outdated
Show resolved
Hide resolved
patrickvonplaten
commented
Dec 6, 2022
tests/pipelines/stable_diffusion/test_stable_diffusion_inpaint.py
Outdated
Show resolved
Hide resolved
patrickvonplaten
commented
Dec 6, 2022
pcuenca
approved these changes
Dec 6, 2022
src/diffusers/pipelines/paint_by_example/pipeline_paint_by_example.py
Outdated
Show resolved
Hide resolved
src/diffusers/pipelines/paint_by_example/pipeline_paint_by_example.py
Outdated
Show resolved
Hide resolved
src/diffusers/pipelines/paint_by_example/pipeline_paint_by_example.py
Outdated
Show resolved
Hide resolved
src/diffusers/pipelines/paint_by_example/pipeline_paint_by_example.py
Outdated
Show resolved
Hide resolved
src/diffusers/pipelines/paint_by_example/pipeline_paint_by_example.py
Outdated
Show resolved
Hide resolved
patrickvonplaten
commented
Dec 7, 2022
patrickvonplaten
commented
Dec 7, 2022
patrickvonplaten
commented
Dec 7, 2022
| @@ -302,7 +302,7 @@ def test_attention_slicing_forward_pass(self): | |||
| output_with_slicing = pipe(**inputs)[0] | |||
|
|
|||
| max_diff = np.abs(output_with_slicing - output_without_slicing).max() | |||
| self.assertLess(max_diff, 1e-5, "Attention slicing should not affect the inference results") | |||
| self.assertLess(max_diff, 1e-3, "Attention slicing should not affect the inference results") | |||
There was a problem hiding this comment.
attention slicing forces different batch size matrix multiplication - there is no way we can guarantee a 1e-5 diff only IMO
There was a problem hiding this comment.
cc @anton-l
New paper -> new folder IMO |
tcapelle
pushed a commit
to tcapelle/diffusers
that referenced
this pull request
Dec 12, 2022
* add paint by example * mkae loading possibel * up * Update src/diffusers/models/attention.py * up * finalize weight structure * make example work * make it work * up * up * fix * del * add * update * Apply suggestions from code review * correct transformer 2d * finish * up * up * up * up * fix * Apply suggestions from code review Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Apply suggestions from code review * up * finish Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
sliard
pushed a commit
to sliard/diffusers
that referenced
this pull request
Dec 21, 2022
* add paint by example * mkae loading possibel * up * Update src/diffusers/models/attention.py * up * finalize weight structure * make example work * make it work * up * up * fix * del * add * update * Apply suggestions from code review * correct transformer 2d * finish * up * up * up * up * fix * Apply suggestions from code review Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Apply suggestions from code review * up * finish Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
|
@patrickvonplaten hello, how to convert diffuser's model to original paintbyexample model type. I find there is no scripts for doing this |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* add paint by example * mkae loading possibel * up * Update src/diffusers/models/attention.py * up * finalize weight structure * make example work * make it work * up * up * fix * del * add * update * Apply suggestions from code review * correct transformer 2d * finish * up * up * up * up * fix * Apply suggestions from code review Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Apply suggestions from code review * up * finish Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds https://github.com/Fantasy-Studio/Paint-by-Example
Conversion script works:
Test weights are uploaded
Check with authors: @Fantasy-Studio