Fix PyCharm/VSCode static type checking for dummy objects #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-l
commented
Dec 7, 2022
src/diffusers/__init__.py
Outdated
Comment on lines
118
to
124
| try: | ||
| if not (is_torch_available() and is_librosa_available()): | ||
| raise OptionalDependencyNotAvailable() | ||
| except OptionalDependencyNotAvailable: | ||
| from ..utils.dummy_torch_and_librosa_objects import * # noqa F403 | ||
| else: | ||
| from .utils.dummy_torch_and_transformers_and_onnx_objects import * # noqa F403 | ||
| from .pipelines import AudioDiffusionPipeline, Mel |
There was a problem hiding this comment.
These were under is_torch_available() before, so I suspect the dummies in dummy_torch_and_librosa_objects.py were created manually, instead of using make fix-copies.
There was a problem hiding this comment.
And there were no import errors because is_torch_available() and is_librosa_available() was correctly used in pipelines.__init__.py instead.
|
The documentation is not available anymore as the PR was closed or merged. |
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
anton-l
commented
Dec 8, 2022
| @@ -29,14 +36,12 @@ | |||
| ) | |||
| from .pipeline_utils import DiffusionPipeline | |||
| from .pipelines import ( | |||
| AudioDiffusionPipeline, | |||
There was a problem hiding this comment.
ah it's further down
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
anton-l
commented
Dec 8, 2022
tcapelle
pushed a commit
to tcapelle/diffusers
that referenced
this pull request
Dec 12, 2022
…e#1596) * Fix PyCharm/VSCode static type checking for dummy objects * Re-add dummies * Fix AudioDiffusion imports * fix import * fix import * Update utils/check_dummies.py Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Update src/diffusers/utils/import_utils.py * Update src/diffusers/__init__.py Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com> * Update src/diffusers/pipelines/stable_diffusion/__init__.py * fix double import Co-authored-by: Pedro Cuenca <pedro@huggingface.co> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
sliard
pushed a commit
to sliard/diffusers
that referenced
this pull request
Dec 21, 2022
…e#1596) * Fix PyCharm/VSCode static type checking for dummy objects * Re-add dummies * Fix AudioDiffusion imports * fix import * fix import * Update utils/check_dummies.py Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Update src/diffusers/utils/import_utils.py * Update src/diffusers/__init__.py Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com> * Update src/diffusers/pipelines/stable_diffusion/__init__.py * fix double import Co-authored-by: Pedro Cuenca <pedro@huggingface.co> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…e#1596) * Fix PyCharm/VSCode static type checking for dummy objects * Re-add dummies * Fix AudioDiffusion imports * fix import * fix import * Update utils/check_dummies.py Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Update src/diffusers/utils/import_utils.py * Update src/diffusers/__init__.py Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com> * Update src/diffusers/pipelines/stable_diffusion/__init__.py * fix double import Co-authored-by: Pedro Cuenca <pedro@huggingface.co> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the fix from huggingface/transformers#16578 to allow PyCharm and VSCode users to jump to the real class definition instead of the
Dummyone (which is picked up by the type checker if not wrapped in an extratry-except).PyCharm needed an index rebuild to see the changes, closing and reopening the IDE should do the trick.
Fixes #1479