Deprecate init image correctly #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
changed the title
|
The documentation is not available anymore as the PR was closed or merged. |
patrickvonplaten
requested review from
patil-suraj,
pcuenca and
anton-l
and removed request for
patil-suraj and
pcuenca
anton-l
approved these changes
Dec 12, 2022
| image: Union[np.ndarray, PIL.Image.Image], | ||
| mask_image: Union[np.ndarray, PIL.Image.Image], | ||
| image: Union[np.ndarray, PIL.Image.Image] = None, | ||
| mask_image: Union[np.ndarray, PIL.Image.Image] = None, |
There was a problem hiding this comment.
mask_image wan't deprecated, was it?
There was a problem hiding this comment.
No but I don't want to change the order here - if image becomes a keyword argument mask image has to become one as well.
SyntaxError: non-default argument follows default argument
tcapelle
pushed a commit
to tcapelle/diffusers
that referenced
this pull request
Dec 12, 2022
Deprecate init image correctl
sliard
pushed a commit
to sliard/diffusers
that referenced
this pull request
Dec 21, 2022
Deprecate init image correctl
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
Deprecate init image correctl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently one has to pass
image=...because it is a required argument. This doesn't correctly deprecate the use ofinit_imagethough.