Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Improve docs #1870

Merged
merged 2 commits into from
Dec 30, 2022
Merged

[Docs] Improve docs #1870

merged 2 commits into from
Dec 30, 2022

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Dec 30, 2022

Make sure docs always show all methods.
Here some very nice documentation of how the doc-builder behaves: https://github.com/huggingface/doc-builder#writing-api-documentation

See differences between:

Using:

- all

is important to not "suppress" other methods. So by default, we should just always use:

- all
- __call__

@@ -30,11 +30,6 @@ Any pipeline object can be saved locally with [`~DiffusionPipeline.save_pretrain

## DiffusionPipeline
[[autodoc]] DiffusionPipeline
- from_pretrained
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yiyixuxu @williamberman @patil-suraj @pcuenca @anton-l Let's make sure to never add any methods here actually because it means that only those methods are shown. If we don't add any methods, we simply show all public methods by default which is much better IMO.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 30, 2022

The documentation is not available anymore as the PR was closed or merged.

@patrickvonplaten patrickvonplaten merged commit ac37384 into main Dec 30, 2022
## StableDiffusionImg2ImgPipeline
[[autodoc]] StableDiffusionImg2ImgPipeline
- all
- __call__
- enable_attention_slicing
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exceptionally I'm duplicating all those enable_attention_slicing from DiffusionPipeline here since this doc page is viewed a lot.

Copy link
Contributor Author

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickvonplaten patrickvonplaten deleted the improve_docs branch December 30, 2022 12:51
yiyixuxu pushed a commit to yiyixuxu/diffusers that referenced this pull request Jan 2, 2023
yiyixuxu added a commit that referenced this pull request Jan 2, 2023
* add a doc page for each pipeline under api/pipelines/stable_diffusion
* add pipeline examples to docstrings
* updated stable_diffusion_2 page
* updated default markdown syntax to list methods based on #1870
* add function decorator

Co-authored-by: yiyixuxu <yixu@Yis-MacBook-Pro.lan>
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* add a doc page for each pipeline under api/pipelines/stable_diffusion
* add pipeline examples to docstrings
* updated stable_diffusion_2 page
* updated default markdown syntax to list methods based on huggingface#1870
* add function decorator

Co-authored-by: yiyixuxu <yixu@Yis-MacBook-Pro.lan>
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants