Fix unused upcast_attn flag in convert_original_stable_diffusion_to_diffusers script #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
pcuenca
approved these changes
Jan 8, 2023
There was a problem hiding this comment.
I think you are right, the argument was seemingly being ignored when passed in the command line (but it worked for Stable Diffusion v2.1 because it was automatically inferred). Let's wait for @patil-suraj to provide his feedback on this :)
|
Great catch @kn ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upcast_attnflag was introduced in this PR https://github.com/huggingface/diffusers/pull/1559/files#diff-575959cae6329573c802ceca78d9a160b9d25948817a9ff37feb37585f819b05R842, however the flag is actually not used.This PR:
upcast_attentionto what's specified by the flag.