do not scale the initial global step by gradient accumulation steps when loading from checkpoint #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen loading from checkpoint
williamberman
requested review from
pcuenca,
yiyixuxu,
sayakpaul and
patrickvonplaten
|
The documentation is not available anymore as the PR was closed or merged. |
|
Cool! |
patrickvonplaten
approved these changes
May 22, 2023
dg845
pushed a commit
to dg845/diffusers
that referenced
this pull request
May 23, 2023
…hen loading from checkpoint (huggingface#3506)
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…hen loading from checkpoint (huggingface#3506)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #3467
This makes sense because we only update the global step every gradient accumulation steps times