Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Dreambooth IF stage II upscaling #3561

Merged
merged 2 commits into from May 31, 2023

Conversation

williamberman
Copy link
Contributor

rebased on top of #3560

Comment on lines -117 to +128
if text_encoder is not None:
pipeline_args["text_encoder"] = accelerator.unwrap_model(text_encoder)

if vae is not None:
pipeline_args["vae"] = vae

if text_encoder is not None:
text_encoder = accelerator.unwrap_model(text_encoder)

# create pipeline (note: unet and vae are loaded again in float32)
pipeline = DiffusionPipeline.from_pretrained(
args.pretrained_model_name_or_path,
tokenizer=tokenizer,
text_encoder=text_encoder,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bug I introduced, we should still always pass text_encoder to the validation pipeline even if it's None since that indicates we pre-computed text embeddings

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 25, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but having some tests for the LoRA mixin would be nice here

@williamberman williamberman merged commit 4f14b36 into huggingface:main May 31, 2023
7 checks passed
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* update dreambooth lora to work with IF stage II

* Update dreambooth script for IF stage II upscaler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants