[WIP] Add Fabric #4201
[WIP] Add Fabric #4201
Conversation
|
Author implementation at https://github.com/sd-fabric/fabric seems pretty straightforward, reading the paper (https://arxiv.org/abs/2307.10159) for more insights! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
sounds good to me |
|
unrelated tests failing - |
|
Hey @shauray8, Thanks a lot for your PR! Can we maybe put this pipeline in the community folder: https://github.com/huggingface/diffusers/tree/main/examples/community? We're sadly a bit overwhelmed by maintenance and aren't able to keep our slow tests clean - if we put this pipeline in the community folder, you can be the official author and the burden to maintain the pipeline is loosened. Would that be ok for you? |
|
Okay, I think it's a good decision, I'll do it before EOD. |
|
@sayakpaul @patrickvonplaten is there anything more I should remove or add? |
| specific language governing permissions and limitations under the License. | ||
| --> | ||
|
|
||
| # FABRIC |
There was a problem hiding this comment.
Could we maybe also add this to the README.md in examples/community? :-)
docs/source/en/_toctree.yml
Outdated
| - local: api/pipelines/fabric | ||
| title: FABRIC |
There was a problem hiding this comment.
| - local: api/pipelines/fabric | |
| title: FABRIC |
|
It should look good now! |
|
Amazing job @shauray8 ! The PR looks very clean now - thanks for bearing with us on this one! |
|
Thank you @sayakpaul @patrickvonplaten and @stevhliu for all the reviews. |
* empty PR * init * changes * starting with the pipeline * stable diff * prev * more things, getting started * more functions * makeing it more readable * almost done testing * var changes * testing * device * device support * maybe * device malfunctions * new new * register * testing * exec does not work * float * change info * change of architecture * might work * testing with colab * more attn atuff * stupid additions * documenting and testing * writing tests * more docs * tests and docs * remove test * empty PR * init * changes * starting with the pipeline * stable diff * prev * more things, getting started * more functions * makeing it more readable * almost done testing * var changes * testing * device * device support * maybe * device malfunctions * new new * register * testing * exec does not work * float * change info * change of architecture * might work * testing with colab * more attn atuff * stupid additions * documenting and testing * writing tests * more docs * tests and docs * remove test * change cross attention * revert back * tests * reverting back to orig * changes * test passing * pipeline changes * before quality * quality checks pass * remove print statements * doc fixes * __init__ error something * update docs, working on dim * working on encoding * doc fix * more fixes * no more dependent on 512*512 * update docs * fixes * test passing * remove comment * fixes and migration * simpler tests * doc changes * green CI * changes * more docs * changes * new images * to community examples * selete * more fixes * changes * fix --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
What does this PR do?
Adds Fabric non-training-based iterative image improvement to diffusion pipeline
code - https://github.com/sd-fabric/fabric
paper - https://huggingface.co/papers/2307.10159
Fixes #4173
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Test Results
Who can review?
@patrickvonplaten