Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure fp16-fix is used as default #4510

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Aug 7, 2023

If the fp16-fix LoRA checkpoint is not used the generated images are always black for the validation set. However the fp16-fix is also not enough to prevent NaN loss during training, so let's do two things here:

    1. Let's make sure to the fp16-fix is used as the default in the README.md
    1. Let's make sure to always put the vae in fp32 during training

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 7, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing.

@patrickvonplaten patrickvonplaten changed the title Make sue fp16-fix is used as default Make sure fp16-fix is used as default Aug 7, 2023
@patrickvonplaten
Copy link
Contributor Author

@patrickvonplaten patrickvonplaten merged commit e1b5b8b into main Aug 7, 2023
9 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@patrickvonplaten patrickvonplaten deleted the patrickvonplaten-patch-1 branch August 7, 2023 13:34
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* Make sue fp16-fix is used as default

* fix vae

* finish

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants