Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix push_to_hub in train_text_to_image_lora_sdxl.py example #4535

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

ra100
Copy link
Contributor

@ra100 ra100 commented Aug 8, 2023

What does this PR do?

Fixes push to hub action in train_text_to_image_lora_sdxl.py example

  • in the last step it failed on missing instance_prompt, it seem the function call didn't match parameters
def save_model_card(
    repo_id: str,
    images=None,
    base_model=str,
    dataset_name=str,
    train_text_encoder=False,
    repo_folder=None,
    vae_path=None,
)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 8, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sayakpaul
Copy link
Member

Could you please run make style && make quality so that the CI tests pass?

@ra100 ra100 force-pushed the fix_lora_sdlx_push_to_hub branch from 3140ce4 to 1e0456d Compare August 9, 2023 05:14
@ra100
Copy link
Contributor Author

ra100 commented Aug 9, 2023

Could you please run make style && make quality so that the CI tests pass?

Sorry, I've missed that, not it should pass.

@ra100
Copy link
Contributor Author

ra100 commented Aug 9, 2023

And now it seem, the checks fail in unrelated files already in main branch

@sayakpaul
Copy link
Member

We're aware of it. But this doesn't restrict this PR from being merged.

@DN6 for awareness.

@sayakpaul sayakpaul merged commit 6c5b5b2 into huggingface:main Aug 9, 2023
7 of 8 checks passed
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants