Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin ruff version for quality checks #4539

Merged
merged 3 commits into from
Aug 9, 2023
Merged

pin ruff version for quality checks #4539

merged 3 commits into from
Aug 9, 2023

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Aug 9, 2023

What does this PR do?

Latest version of ruff breaks some code quality checks. This PR pins the ruff so that QC tests pass.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 requested a review from sayakpaul August 9, 2023 08:44
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 9, 2023

The documentation is not available anymore as the PR was closed or merged.

@sayakpaul
Copy link
Member

sayakpaul commented Aug 9, 2023

@DN6 the failing test needs to be fixed.

Here's a relevant PR: https://github.com/huggingface/diffusers/pull/3341/files

@DN6
Copy link
Collaborator Author

DN6 commented Aug 9, 2023

@sayakpaul Code QC tests are passing. The current failing test has to do with DownloadTests.test_cached_files_are_used_when_no_internet running into a timeout.

@sayakpaul sayakpaul merged commit da0e2fc into main Aug 9, 2023
10 checks passed
@sayakpaul sayakpaul deleted the qc-fixes branch August 9, 2023 11:16
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* pin ruff version for quality checks

* update dependency versions table

---------

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* pin ruff version for quality checks

* update dependency versions table

---------

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants