Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config_file to from_single_file #4614

Merged
merged 11 commits into from
Aug 18, 2023

Conversation

zuojianghua
Copy link
Contributor

add config_file to from_single_file,
when the download_from_original_stable_diffusion_ckpt use

What does this PR do?

add config_file to from_single_file

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten and @sayakpaul

add config_file to from_single_file, 
when the download_from_original_stable_diffusion_ckpt use
add config_file to from_single_file,
when the download_from_original_stable_diffusion_ckpt use
@zuojianghua zuojianghua changed the title Update loaders.py add config_file to from_single_file Aug 15, 2023
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@sayakpaul
Copy link
Member

Thanks for your PR. Could you run make style && make quality to ensure the code quality is okay?

@sayakpaul sayakpaul requested review from yiyixuxu and DN6 August 15, 2023 07:39
@zuojianghua
Copy link
Contributor Author

Thanks for your PR. Could you run make style && make quality to ensure the code quality is okay?

hi, i wos run 'make style && make quality', it got some error. it just stop with 'make: *** [Makefile:43: quality] Error 1'

when 'black --check examples scripts src tests utils' there is

would reformat /workspace/src/diffusers/training_utils.py
would reformat /workspace/src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_attend_and_excite.py

Oh no! 💥 💔 💥
2 files would be reformatted, 585 files would be left unchanged.

It looks like the other two files have code formatting issues

src/diffusers/loaders.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@DN6
Copy link
Collaborator

DN6 commented Aug 17, 2023

@zuojianghua Are you still running into issues with make style && make quality?

@zuojianghua
Copy link
Contributor Author

it is failed in tests/models/test_lora_layers.py::SDXLLoraLoaderMixinTests::test_load_lora_locally

=========================== short test summary info ============================
FAILED tests/models/test_lora_layers.py::SDXLLoraLoaderMixinTests::test_load_lora_locally - AssertionError: False is not true
==== 1 failed, 1054 passed, 106 skipped, 160 warnings in 102.16s (0:01:42) =====
Error: Process completed with exit code 1.

@sayakpaul
Copy link
Member

#4652 is merged and the error should go away.

@DN6
Copy link
Collaborator

DN6 commented Aug 17, 2023

@zuojianghua Could you please run make style && make quality again to address the code quality checks. We should be ready to merge after that.

@zuojianghua
Copy link
Contributor Author

@zuojianghua Could you please run make style && make quality again to address the code quality checks. We should be ready to merge after that.

done

@zuojianghua
Copy link
Contributor Author

@DN6 LGTM

@DN6 DN6 merged commit 74d902e into huggingface:main Aug 18, 2023
9 checks passed
@zuojianghua zuojianghua deleted the zuojianghua-patch-1-1 branch August 18, 2023 16:35
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* Update loaders.py

add config_file to from_single_file, 
when the download_from_original_stable_diffusion_ckpt use

* Update loaders.py

add config_file to from_single_file,
when the download_from_original_stable_diffusion_ckpt use

* change config_file to original_config_file

* make style && make quality

---------

Co-authored-by: jianghua.zuo <jianghua.zuo@weimob.com>
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* Update loaders.py

add config_file to from_single_file, 
when the download_from_original_stable_diffusion_ckpt use

* Update loaders.py

add config_file to from_single_file,
when the download_from_original_stable_diffusion_ckpt use

* change config_file to original_config_file

* make style && make quality

---------

Co-authored-by: jianghua.zuo <jianghua.zuo@weimob.com>
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants