Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix typos, improve, update at Using Diffusers' Task page #5611

Merged
merged 9 commits into from
Nov 7, 2023
Merged

[Docs] Fix typos, improve, update at Using Diffusers' Task page #5611

merged 9 commits into from
Nov 7, 2023

Conversation

tolgacangoz
Copy link
Contributor

What does this PR do?

Kandinsky doesn't want fp16 due to deprecation; ogkalu and kohbanye don't have .safetensor; add make_image_grid for better visualization.
@stevhliu @yiyixuxu @DN6

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

…ation; ogkalu and kohbanye don't have safetensor; add make_image_grid for better visualization
@tolgacangoz tolgacangoz changed the title Fix typos, improve, update at Using Diffusers' Task page [Docs] Fix typos, improve, update at Using Diffusers' Task page Nov 1, 2023
@tolgacangoz tolgacangoz changed the title [Docs] Fix typos, improve, update at Using Diffusers' Task page [Docs] Fix typos, improve, update at Using Diffusers' Task page Nov 1, 2023
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the issues and making good use of the make_image_grid function!

docs/source/en/using-diffusers/depth2img.md Outdated Show resolved Hide resolved
docs/source/en/using-diffusers/img2img.md Outdated Show resolved Hide resolved
docs/source/en/using-diffusers/inpaint.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 4, 2023

The documentation is not available anymore as the PR was closed or merged.

@tolgacangoz tolgacangoz marked this pull request as draft November 6, 2023 09:35
@tolgacangoz tolgacangoz marked this pull request as ready for review November 6, 2023 09:42
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for your efforts in making these docs better!

@stevhliu stevhliu merged commit 7942bb8 into huggingface:main Nov 7, 2023
11 checks passed
kashif pushed a commit to kashif/diffusers that referenced this pull request Nov 11, 2023
…ggingface#5611)

* Fix typos, improve, update; kandinsky doesn't want fp16 due to deprecation; ogkalu and kohbanye don't have safetensor; add make_image_grid for better visualization

* Update inpaint.md

* Remove erronous Space

* Update docs/source/en/using-diffusers/conditional_image_generation.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update img2img.md

* load_image() already converts to RGB

* Update depth2img.md

* Update img2img.md

* Update inpaint.md

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@tolgacangoz tolgacangoz deleted the fix-typos-using-diffusers-tasks branch November 30, 2023 07:23
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
…ggingface#5611)

* Fix typos, improve, update; kandinsky doesn't want fp16 due to deprecation; ogkalu and kohbanye don't have safetensor; add make_image_grid for better visualization

* Update inpaint.md

* Remove erronous Space

* Update docs/source/en/using-diffusers/conditional_image_generation.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update img2img.md

* load_image() already converts to RGB

* Update depth2img.md

* Update img2img.md

* Update inpaint.md

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants