Explicit torch/flax dependency check #5673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DN6
changed the title
DN6
changed the title
|
FYI, adding these checks adds 2 mins to the PR tests. We can speed it up by adding a dedicated image for dependency testing. |
|
The documentation is not available anymore as the PR was closed or merged. |
|
Hmm adding 2 mins extra for fast tests seems to be long. But the proposed solution works for me. |
|
Ok for now! Let's clean up the tests after the release |
|
Thanks for the fix! |
kashif
pushed a commit
to kashif/diffusers
that referenced
this pull request
Nov 11, 2023
* explicit torch dependency check * update * update * update
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* explicit torch dependency check * update * update * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Dependency tests aren't catching import issues caused when certain soft dependencies are introduced via Mixins (see #5668)
This PR tests soft dependencies when either torch or flax is installed, so that these import issues can be be caught.
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.