[LCM] Fix img2img #5698
Merged
[LCM] Fix img2img #5698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
sayakpaul
pushed a commit
that referenced
this pull request
Nov 8, 2023
* [LCM] Fix img2img * make fix-copies * make fix-copies * make fix-copies * up
kashif
reviewed
Nov 8, 2023
| @@ -378,7 +378,7 @@ def set_processor(self, processor: "AttnProcessor", _remove_lora: bool = False) | |||
| _remove_lora (`bool`, *optional*, defaults to `False`): | |||
| Set to `True` to remove LoRA layers from the model. | |||
| """ | |||
| if hasattr(self, "processor") and _remove_lora and self.to_q.lora_layer is not None: | |||
| if not USE_PEFT_BACKEND and hasattr(self, "processor") and _remove_lora and self.to_q.lora_layer is not None: | |||
There was a problem hiding this comment.
@patrickvonplaten with this change the test for self.to_q.lora_layer is not needed since when USE_PEFT_BACKEND = True, the self.to_q will be nn.Linear and one will get an error
I had the same idea to use USE_PEFT_BACKEND for the wuerstchen prior pipeline see #5704
There was a problem hiding this comment.
Could you add that change in #5704?
kashif
pushed a commit
to kashif/diffusers
that referenced
this pull request
Nov 11, 2023
* [LCM] Fix img2img * make fix-copies * make fix-copies * make fix-copies * up
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* [LCM] Fix img2img * make fix-copies * make fix-copies * make fix-copies * up
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* [LCM] Fix img2img * make fix-copies * make fix-copies * make fix-copies * up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug with img2img