Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests due to Posix Path #6627

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix failing tests due to Posix Path #6627

merged 1 commit into from
Jan 18, 2024

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Jan 18, 2024

What does this PR do?

Using pathlib with URLs will remove the necessary // from https:// strings. This is causing tests that rely on load_hf_numpy to fail. This function is only used in tests so we don't need to use Posix here.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 merged commit a65ca8a into main Jan 18, 2024
16 checks passed
HelloWorldBeginner pushed a commit to HelloWorldBeginner/diffusers that referenced this pull request Jan 19, 2024
* origin/main:
  Fix failing tests due to Posix Path (huggingface#6627)
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants