Add CLI tool #32
Merged
Add CLI tool #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lines 7 to 8 in 84cc793 needs to be updated |
mishig25
reviewed
Dec 1, 2021
| text = f.read() | ||
|
|
||
| page_info = {"package_name": package_name, "page": source_file.with_suffix(".html").relative_to(doc_folder)} | ||
| text = convert_rst_to_mdx(text, page_info, add_imports=False) |
There was a problem hiding this comment.
Does convert_md_to_mdx has to be somewhere here as well?
There was a problem hiding this comment.
No this is only for rst files (I can add a check).
LysandreJik
approved these changes
Dec 1, 2021
| "Cannot determine a default for package_name as the file passed is not in a git directory. " | ||
| "Please pass along a package_name." | ||
| ) | ||
| doc_folder = git_folder / "docs/source" |
There was a problem hiding this comment.
That's not robust for windows but I'm not sure we care in a v1
There was a problem hiding this comment.
Can do two / which should be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some CLI tools with:
build_docand makes it easier to launch it from anywhere.