Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding label distribution measurement #202

Merged
merged 18 commits into from
Jul 27, 2022
Merged

Adding label distribution measurement #202

merged 18 commits into from
Jul 27, 2022

Conversation

sashavor
Copy link
Contributor

Finally adding that label distribution measurement! thanks @lvwerra for all your guidance 馃

@sashavor sashavor requested a review from lvwerra July 26, 2022 14:13
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 26, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Overall looks good, left a few nits. Main change I am proposing is using scipy instead of pandas for the skew computation since it avoids wrapping in a Series object.

measurements/label_distribution/label_distribution.py Outdated Show resolved Hide resolved
measurements/label_distribution/label_distribution.py Outdated Show resolved Hide resolved
measurements/label_distribution/label_distribution.py Outdated Show resolved Hide resolved
measurements/label_distribution/label_distribution.py Outdated Show resolved Hide resolved
measurements/label_distribution/requirements.txt Outdated Show resolved Hide resolved
measurements/label_distribution/label_distribution.py Outdated Show resolved Hide resolved
measurements/label_distribution/label_distribution.py Outdated Show resolved Hide resolved
sashavor and others added 8 commits July 26, 2022 17:06
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
removing imdb example from docstring
Sasha Luccioni and others added 8 commits July 26, 2022 17:33
@lvwerra lvwerra merged commit 4adef25 into main Jul 27, 2022
@lvwerra lvwerra deleted the label_distribution branch July 27, 2022 07:45
mathemakitten pushed a commit that referenced this pull request Aug 3, 2022
* adding label distribution measurement

* removing comment

* Update measurements/label_distribution/label_distribution.py

Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>

* Update measurements/label_distribution/label_distribution.py

Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>

* Update measurements/label_distribution/requirements.txt

Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>

* Update label_distribution.py

removing imdb example from docstring

* fixing style

* Update README.md

* Update measurements/label_distribution/README.md

Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>

* Update label_distribution.py

removing if statement

* Update label_distribution.py

adding scipy bibtex

* Update README.md

updating references

* Update label_distribution.py

* Update label_distribution.py

* one final style and quality?

Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants