Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizing the tokenizer of GoogleBLEU and making it 13a #26

Merged
merged 2 commits into from May 3, 2022

Conversation

sashavor
Copy link

@sashavor sashavor commented May 2, 2022

I did the same thing for google BLEU as I did for BLEU (see the PR).

I triple-checked the examples and they give the same values as before! cc @lhoestq 馃槈

I think this is the last metric that takes tokenized inputs, so we should be good in this sense.

@sashavor sashavor requested a review from lvwerra May 2, 2022 21:41
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

metrics/google_bleu/README.md Outdated Show resolved Hide resolved
Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
@sashavor sashavor merged commit 4ef2362 into main May 3, 2022
@lvwerra lvwerra deleted the google-bleu-tokenizer branch July 24, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants