Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating zero shot img classification #380

Merged
merged 9 commits into from
Oct 13, 2022

Conversation

silvererudite
Copy link
Contributor

@silvererudite silvererudite commented Oct 6, 2022

Partially fixes huggingface/huggingface.js#330
Hi @merveenoyan ...I added task desc, models and evaluation metric. I'm not sure what to put under datasets wud love some pointers. Also pls suggest any updates and fixes required. Thanks

Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks very good to me! I left a couple of comments, can you check it out 🙂 Thanks a lot for working on this ❤️🤗

tasks/src/zero-shot-image-classification/data.ts Outdated Show resolved Hide resolved
tasks/src/zero-shot-image-classification/data.ts Outdated Show resolved Hide resolved
Copy link
Contributor Author

@silvererudite silvererudite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @merveenoyan as per your suggestion I added a brief desc in about.md instead of the data.ts file

Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, I'll be happy to merge after the comments are addressed 🙂 great work!

tasks/src/zero-shot-image-classification/about.md Outdated Show resolved Hide resolved
tasks/src/zero-shot-image-classification/about.md Outdated Show resolved Hide resolved
tasks/src/zero-shot-image-classification/data.ts Outdated Show resolved Hide resolved
tasks/src/zero-shot-image-classification/data.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge after I get a local build 🙂

tasks/src/zero-shot-image-classification/about.md Outdated Show resolved Hide resolved
Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have indentation and key-space problems, you can lint using eslint, other than that I will merge once it's done 🙂

@@ -0,0 +1,9 @@
## About the Task

Zero shot image classification works by transferring knowledge learnt during training of one model, to classify novel classes that was not present in the training data. So this a variation of [transfer learning](https://www.youtube.com/watch?v=BqqfQnyjmgg). For instance, a model trained to differentiate cars from airplanes can be used to classify images of ships.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Zero shot image classification works by transferring knowledge learnt during training of one model, to classify novel classes that was not present in the training data. So this a variation of [transfer learning](https://www.youtube.com/watch?v=BqqfQnyjmgg). For instance, a model trained to differentiate cars from airplanes can be used to classify images of ships.
Zero shot image classification works by transferring knowledge learnt during training of one model, to classify novel classes that was not present in the training data. So this is a variation of [transfer learning](https://www.youtube.com/watch?v=BqqfQnyjmgg). For instance, a model trained to differentiate cars from airplanes can be used to classify images of ships.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ..so sorry about these little slip ups😅..will fix them and format with eslint now.

@merveenoyan
Copy link
Contributor

merveenoyan commented Oct 12, 2022

@silvererudite the youtubeId is the part that has key-value spacing related lint error, did you format it?

@silvererudite
Copy link
Contributor Author

@silvererudite the youtubeId is the part that has key-value spacing related lint error, did you format it?

@merveenoyan how do I find the .eslintrc file for this project...I ran eslint but it didn't seem to detect the error you mentioned

@merveenoyan merveenoyan merged commit 246e411 into huggingface:main Oct 13, 2022
@merveenoyan
Copy link
Contributor

@silvererudite I will format it myself later, congrats on the merger! What is your 🤗 Hub handle so I can add your name at the end of the doc?

@silvererudite
Copy link
Contributor Author

@silvererudite I will format it myself later, congrats on the merger! What is your 🤗 Hub handle so I can add your name at the end of the doc?

Thanks @merveenoyan ... my hub handle is Shamima .. https://huggingface.co/Shamima

@silvererudite
Copy link
Contributor Author

btw..did I face this formatting issue because I cloned the repo and locally pushed the changes? would it not have been the case if I pushed commits from the browser?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero Shot Image Classification Task Page
2 participants