Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated yaml file doc to use checkout@v3 #436

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

clatonhendricks
Copy link
Contributor

Node 12 has been out of support since April 2022, as a result Github has started the deprecation process of Node 12 for GitHub Actions. More details below https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Verified the fix with a local action file with v3 version seems to fix the error in Git Actions

Node 12 has been out of support since April 2022, as a result Github has started the deprecation process of Node 12 for GitHub Actions. More details below 
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Verified the fix with a local action file with v3 version seems to fix the error in Git Actions
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me but tagging @borisdayma who contributed this workflow originally:

Original PR (was in a different repo back then): huggingface/huggingface_hub#221

@osanseviero
Copy link
Member

FYI @nateraw for https://github.com/nateraw/huggingface-sync-action

@clatonhendricks
Copy link
Contributor Author

Is there an action pending on my behalf since this is my first time updating docs.

@julien-c
Copy link
Member

merging, thanks for your contribution!

@julien-c julien-c merged commit e8068fb into huggingface:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants