Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tabby Docker Space docs #947

Merged
merged 8 commits into from
Oct 4, 2023
Merged

Add Tabby Docker Space docs #947

merged 8 commits into from
Oct 4, 2023

Conversation

wsxiaoys
Copy link
Contributor

No description provided.

julien-c
julien-c reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cool!

do you have an example of a running instance on a Space?

@wsxiaoys
Copy link
Contributor Author

I have just unpaused the template space that was being used in the document:

Link: https://huggingface.co/spaces/TabbyML/tabby-template-space
Direct URL: https://tabbyml-tabby-template-space.hf.space/

@julien-c
Copy link
Member

pinging @mishig25 for a review as he's very interested in code generation extensions!

@mishig25
Copy link
Collaborator

@wsxiaoys could you add your new file in the toctree here ?

wsxiaoys and others added 2 commits September 12, 2023 17:10
@wsxiaoys
Update _toctree.yml
7b79572
@wsxiaoys @mishig25
Apply suggestions from code review
5f94177 
Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu>
@wsxiaoys
Copy link
Contributor Author

@wsxiaoys could you add your new file in the toctree here ?

added

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 12, 2023 •
edited

The documentation is not available anymore as the PR was closed or merged.

@wsxiaoys
Copy link
Contributor Author

Kindly ping :)

@wsxiaoys
Copy link
Contributor Author

👀

osanseviero
osanseviero reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I have a couple of suggestions but overall looks great! 🔥

docs/hub/spaces-sdks-docker-tabby.md Outdated Show resolved Hide resolved
docs/hub/spaces-sdks-docker-tabby.md Outdated Show resolved Hide resolved
docs/hub/spaces-sdks-docker-tabby.md Outdated Show resolved Hide resolved
docs/hub/spaces-sdks-docker-tabby.md Outdated Show resolved Hide resolved
docs/hub/spaces-sdks-docker-tabby.md Outdated Show resolved Hide resolved
wsxiaoys and others added 2 commits September 19, 2023 22:42
@wsxiaoys @osanseviero
Apply suggestions from code review
04e36ac 
Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>
@wsxiaoys
Update spaces-sdks-docker-tabby.md
fec7ad7
osanseviero
osanseviero approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If @mishig25 is happy with this, let's merge!

@wsxiaoys
Copy link
Contributor Author

Kindly ping @mishig25 ~

@wsxiaoys
Copy link
Contributor Author

wsxiaoys commented Oct 2, 2023

Another ping to @mishig25 👀

mishig25
mishig25 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@mishig25
Copy link
Collaborator

mishig25 commented Oct 2, 2023

Will merge after CI succeeds https://github.com/huggingface/hub-docs/actions/runs/6238190311/job/17322615240?pr=947

@mishig25
Copy link
Collaborator

mishig25 commented Oct 2, 2023

The error is not related to PR. I'm checking it 👁️

@wsxiaoys
Copy link
Contributor Author

wsxiaoys commented Oct 2, 2023 

4:42:15 PM [vite-plugin-svelte] /tmp/tmpx_0uetoq/kit/node_modules/@sveltejs/kit/src/runtime/components/error.svelte:12:8 'IconCopyLink' is not defined

Seems triggering an unrelated error - shall i do a rebase?

@wsxiaoys
Copy link
Contributor Author

wsxiaoys commented Oct 3, 2023

Rebased against main branch

@mishig25 mishig25 merged commit 06694c5 into huggingface:main Oct 4, 2023
1 check passed
@mishig25
Copy link
Collaborator

mishig25 commented Oct 4, 2023

@wsxiaoys thanks a lot for working on it! The page is live https://huggingface.co/docs/hub/spaces-sdks-docker-tabby
image

@wsxiaoys
Copy link
Contributor Author

wsxiaoys commented Oct 4, 2023

Great! Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-c julien-c julien-c left review comments

@osanseviero osanseviero osanseviero approved these changes

@mishig25 mishig25 mishig25 approved these changes

@McPatate McPatate Awaiting requested review from McPatate

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wsxiaoys @julien-c @mishig25 @HuggingFaceDocBuilderDev @osanseviero @merveenoyan