Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safetensors sharded model inspector does not work in subdirs #588

Closed
madgetr opened this issue Mar 28, 2024 · 8 comments · Fixed by #594
Closed

Safetensors sharded model inspector does not work in subdirs #588

madgetr opened this issue Mar 28, 2024 · 8 comments · Fixed by #594

Comments

@madgetr
Copy link
Contributor

madgetr commented Mar 28, 2024

image
It seems that the model inspector for sharded safetensors does not work when the model is in a sub directory.

@coyotte508
Copy link
Member

cc @mishig25 @julien-c

@madgetr
Copy link
Contributor Author

madgetr commented Mar 28, 2024

I'll fix it if I have time this weekend

@coyotte508
Copy link
Member

We have an internal PR open for the hub that should fix it @madgetr (cc @mishig25)

@mishig25
Copy link
Collaborator

Yep it should be fixed by #563

the hf.co needs to use latest hf.js

@coyotte508
Copy link
Member

coyotte508 commented Mar 29, 2024

hmm thinking about it the issue is sharded models, and the hub PR is for single-file models I think

This issue is related to #592 I think and does need some work in hub.js (and some in the hub itself)

@julien-c
Copy link
Member

@madgetr can you provide a link to the model (if it's a public one) you screenshoted that has a safetensors sharded file inside a subdir? So we can make sure it works:)

@madgetr
Copy link
Contributor Author

madgetr commented Mar 29, 2024

https://huggingface.co/Alignment-Lab-AI/ALAI-gemma-7b/tree/main/7b/1

@mishig25
Copy link
Collaborator

mishig25 commented Apr 2, 2024

thanks a lot for notifying the issue again. The fix is deployed. You can see a working example at: https://huggingface.co/Alignment-Lab-AI/ALAI-gemma-7b/tree/main/7b/1?show_tensors=7b%2F1%2Fmodel.safetensors.index.json

Screenshot 2024-04-02 at 12 34 23 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants