Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Adjust feature extraction expected result check #196

Merged
merged 2 commits into from
May 19, 2023

Conversation

vvmnnnkv
Copy link
Collaborator

Feature extraction model can have 3-d output.
Fixes #194

Copy link
Member

@coyotte508 coyotte508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coyotte508 coyotte508 merged commit 2a8fc43 into huggingface:main May 19, 2023
1 check passed
@lisandropuzzolo
Copy link
Contributor

Thank you vvmnnnkv!
I've written a PHP SDK for huggingface similar than this one.

I would like to add to this project (huggingface.js) some of my features not present, like for example ejecute different tasks for one model (right now huggingface.js only allows to ejecute the default task).

Is there any guide to download the project, execute tests, and propose changes?
Thanks in advance!

@coyotte508
Copy link
Member

coyotte508 commented May 19, 2023

I would like to add to this project (huggingface.js) some of my features not present, like for example ejecute different tasks for one model (right now huggingface.js only allows to ejecute the default task).

That would be most welcome :)

Is there any guide to download the project, execute tests, and propose changes?

You can check the main README.md and also https://github.com/huggingface/huggingface.js/tree/main/packages/inference

Basically you need corepack enable (to add pnpm to node) and pnpm install in the project, then you can start devloping

Edit: see https://github.com/huggingface/huggingface.js/blob/main/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not every feature extraction model returns an array of numbers
3 participants