[model libraries] simplified setup for countDownloads #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
requested review from
osanseviero,
SBrandeis,
gary149 and
Wauplin
as code owners
julien-c
commented
Feb 15, 2024
| // match multiple possible filenames | ||
| | { terms?: { path: string[] } } | ||
| // match a wildcard | ||
| | { wildcard?: { path: string } }; |
There was a problem hiding this comment.
note to reviewers: I only expose the filter option because:
- it's simpler: every library except for diffusers is using it.
- i had typings issues/conflicts with the Chai library when defining a type that contains a property named
should. cc @coyotte508. Rather than fightining the tooling, i decided to work around it
Wauplin
approved these changes
Feb 16, 2024
| // match multiple possible filenames | ||
| | { terms?: { path: string[] } } | ||
| // match a wildcard | ||
| | { wildcard?: { path: string } }; |
There was a problem hiding this comment.
(nit) FWIW, wildcards are not optimized in ES. Since we only use them to filter by suffix (*.onnx, *.sentis, etc.), we could use a reverse-token-filter + a prefix filter.
There was a problem hiding this comment.
hmm maybe cc @SBrandeis or @co42 for information
There was a problem hiding this comment.
We would need to reindex everything to add a reverse token filter. If the wildcard is fast enough let's use that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #482
note to reviewers: I only expose the
filteroption because:should. cc @coyotte508. Rather than fightining the tooling, i decided to work around it