Gguf updates #543
Merged
Gguf updates #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mishig25
commented
Mar 11, 2024
•
mishig25
commented
- Use length rather than newOffset (discussed here)
- custom fetch fn (discussed here)
julien-c
approved these changes
Mar 12, 2024
packages/gguf/src/gguf.ts
Outdated
| @@ -185,8 +188,8 @@ export interface GGUFParseOutput { | |||
| tensorInfos: GGUFTensorInfo[]; | |||
| } | |||
|
|
|||
| export async function gguf(url: string): Promise<GGUFParseOutput> { | |||
| const r = new RangeView(url); | |||
| export async function gguf(url: string, _fetch: typeof fetch = fetch): Promise<GGUFParseOutput> { | |||
There was a problem hiding this comment.
Suggested change
| export async function gguf(url: string, _fetch: typeof fetch = fetch): Promise<GGUFParseOutput> { | |
| export async function gguf(url: string, params: { | |
| /** | |
| * Custom fetch function to use instead of the default one, for example to use a proxy or edit headers. | |
| */ | |
| fetch?: typeof fetch; | |
| }): Promise<GGUFParseOutput> { |
any way to pass it like this for consistency with safetensors?
packages/gguf/src/gguf.ts
Outdated
| export async function gguf(url: string): Promise<GGUFParseOutput> { | ||
| const r = new RangeView(url); | ||
| export async function gguf(url: string, _fetch: typeof fetch = fetch): Promise<GGUFParseOutput> { | ||
| const r = new RangeView(url, _fetch); |
| @@ -223,7 +226,7 @@ export async function gguf(url: string): Promise<GGUFParseOutput> { | |||
| throw new Error("Unsupported metadata type: " + valueType); | |||
| } | |||
|
|
|||
| let valueResult: { value: MetadataValue; newOffset: number } | undefined; | |||
| let valueResult: ReturnType<typeof readMetadataValue> | undefined; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.