Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to fork this Hugging Face hub GitHub repository to do a translation. Is this feasible? #1601

Closed
2404589803 opened this issue Aug 18, 2023 · 11 comments

Comments

@2404589803
Copy link
Contributor

I want to fork this Hugging Face hub GitHub repository to do a translation. Is this feasible? @xianbaoqian

@2404589803
Copy link
Contributor Author

translation to chinese.

@2404589803
Copy link
Contributor Author

and build a CN folder, it's can or not?

@xianbaoqian
Copy link

Hi @1359989

Thank you for offering to translate the Python Hub documentation into Chinese! That would be incredibly helpful for our Chinese user community.

Dear Hub team,

Is this possible to add multi-language support in the docs? (apart from the reference section)

image

I took a look at the Diffusers library, and it's great that they have built-in support for multi-lingual.
image

Alternatively, for the Hub library, having a forked repo with translations that we link to from the main README could work well if built-in multi-lingual support is too complex. User can read the markdown file preview and we can also post some of the translated content on our Chinese social medias (e.g. WeChat / Zhihu)

Also it would appreciate if you can help with some instructions on how to preview the docs page locally to catch early issues. doc-builder preview doesn't seem to work well.

Any thoughts / suggestions? Looking forward to collaborating to make the Hub docs more accessible to Chinese users.

Thanks,
Tiezhen

@Wauplin
Copy link
Contributor

Wauplin commented Aug 18, 2023

Hi @1359989 @xianbaoqian 👋 Thank you both for offering to translate huggingface_hub's content! Actually this is something we've discussed internally not that long ago. Our plan is to do the same as in transformers:

  • provide several a different README file for each language, referencing each other
  • provide the same translating guide
  • have 1 folder per language in the docs/, which would enable multi-lingual support as in transformers and diffusers

I'll keep you updated about the progress :)

@Wauplin
Copy link
Contributor

Wauplin commented Aug 18, 2023

I just opened an issue (#1602) to enable translations to other languages than English (like in transformers/diffusers).

@2404589803
Copy link
Contributor Author

One more question,my pull request Should I submit my pull request after I finish the translation, or before I finish the translation?@Wauplin

@2404589803
Copy link
Contributor Author

Because I first to do it , I don't know how to do. 😥😥😥😥😥

@Wauplin
Copy link
Contributor

Wauplin commented Aug 18, 2023

@jimtom40395 It's not yet possible to translate documentation on this repo. The best you can do at the moment, if you want, is to translate the existing guides offline and wait for my PR to be merged first. I'll provide you more details once it's done (I'm not 100% sure yet how we will proceed). Due to holidays the PR will not be merged before the end of August.

@2404589803
Copy link
Contributor Author

No problem. The work I'm doing now is to fork the repository to my github local, and then do the translation.Also, I would like to thank you for taking the time to reply to me amidst your busy schedule.☺@Wauplin

@Wauplin
Copy link
Contributor

Wauplin commented Aug 30, 2023

@jimtom40395 Translating documentation for this repo is now possible! (see #1602).

To start translating to a new language, you should check if an issue already exists (here) which is not the case for chinese at the moment. Then if it doesn't exist, you should create a new one to track the work progress. For example, here is the issue for Korean translation. Then you can share in your community and start organizing the work!

@Wauplin
Copy link
Contributor

Wauplin commented Aug 30, 2023

I'll therefore close this issue.

@Wauplin Wauplin closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants