-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃寪 [i18n-DE] Translating docs to German #1645
Comments
I have started a German translation of the docs. Mainly for myself in order to deeply understand the hub functionalities along the way. I'll release translated docs as I go along. What do you prefer?
|
One more thing I want to mention: However, when looking at the German translation for Transformers, the formal "Sie" seems to have been used. Hence, I also used "Sie" to keep the help docs consistent. Do you have any strong opinions about this topic? |
Thanks for opening this issue and proactively working on it @martinbrose! Please let me know if you have any questions about the English documentation.
That's a good question. I'm not opinionated about how to address people in German but I'd be in favor in following
Not much preferences to be honest. I'd say 1 PR every time you work on translating documentation. If you do 3 guides in a row, then let's have 1 PR for 3 guides. If you've only done half of a guide, that's also fine for a PR as long as you document the fact that it's not complete. The most important part IMO is to mention you're working on a section beforehand so that we don't have duplicate work if other German-speaking community members starts helping on this issue (so all good, since you've already mentioned your sections in this issue description). |
Actually, I might have two questions:
|
No idea. I just removed it 馃槃
You can do as the |
maybe still ping @mishig25 to check if it's (that specific point of the README) the current best practice for doc structuration? cc @osanseviero too |
I think this was referring to the number of docs in 馃 Transformers. |
For now, I have saved it as |
I finished the first round of translations into German. |
Hi @martinbrose, for now, the current practice of having README_[lang].md works 馃憤 |
@martinbrose I realized a few things when going through the docs:
Apart from that, everything looks good to me. Well done! 馃嚛馃嚜 |
Hi @Wauplin, no prob. Will attend to this in the next couple of days. |
Ok, Git vs HTTP page is done. However, I unfortunately have no idea how to link the |
Hmm, that's a good question I haven't thought about. I see 2 options: either remove the Referenz section or hardcode the URL to redirect to the EN cc @mishig25 if you have a better idea. |
@Wauplin I pushed the additional translated file to the original translation branch Should I just re-open an additional pull request based on that branch or create a new branch, add the file and create the pull request from there? |
@martinbrose I think the easiest is to create a new branch directly from this one, merge main into it and push that to the Github:
If you get a merge conflict while merging main into the new branch and it's too complicated to fix it then it's best to start from a clean state and add the file there. |
HI @Wauplin, I decided the no-experiments route and started a new branch from main. ;) I still struggle with the Reference guides though. I tried several things in the |
Hey @martinbrose sorry I couldn't check this today. I'll have to postpone to Monday. Thanks for looking into it though. I'll find a solution somehow, otherwise we'll just "remove" the section in the TOC. Have a nice weekend! |
That was most likely for the best 馃槃 I've just reviewed and merged #1686! |
Very nice to have this done!! Big milestone for the German-speaking community! |
Hi!
Let's bring the documentation to all the German-speaking community 馃寪
Who would want to translate? Please follow the 馃 TRANSLATING guide. Here is a list of the files ready for translation. Let us know in this issue if you'd like to translate any, and we'll add your name to the list.
Some notes:
de
inside the source folder.de/_toctree.yml
; please follow the order of the English version.README
Get Started section
Guides section
The text was updated successfully, but these errors were encountered: