Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve compatibility issues when calling subprocess.run #104

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

SBrandeis
Copy link
Contributor

The check_output of subprocess.run argument is not available in Python 3.6, but the lib is advertized to be compatible with Python >= 3.6

@julien-c
Copy link
Member

hmm the lib was/is tested under Python 3.6 no?

@SBrandeis
Copy link
Contributor Author

SBrandeis commented Jun 11, 2021

Calls to subprocess.run are only made when using LFS, and this is only tested for 3.9

@julien-c
Copy link
Member

oh yes that's in tests only, right

Why do you need to run the tests in Py3.6?

@SBrandeis
Copy link
Contributor Author

My virtualenv for huggingface_hub is 3.6 😛

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM! Should we also run tests for python 3.6 for git-lfs?

@julien-c
Copy link
Member

Should we also run tests for python 3.6 for git-lfs?

I don't really see a need for this

@SBrandeis SBrandeis merged commit 5e4bccd into main Jun 14, 2021
@SBrandeis SBrandeis deleted the test-python-version branch June 14, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants