Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[huggingface_hub] Support for spaces #108

Merged
merged 9 commits into from
Jun 15, 2021
Merged

[huggingface_hub] Support for spaces #108

merged 9 commits into from
Jun 15, 2021

Conversation

julien-c
Copy link
Member

No description provided.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this is clean! LGTM @julien-c

@@ -25,6 +25,7 @@
HUGGINGFACE_CO_URL_TEMPLATE,
PYTORCH_WEIGHTS_NAME,
REPO_TYPE_DATASET,
REPO_TYPE_SPACE,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@@ -21,9 +21,13 @@
)

REPO_TYPE_DATASET = "dataset"
REPO_TYPES = [None, REPO_TYPE_DATASET]
REPO_TYPE_SPACE = "space"
REPO_TYPES = [None, REPO_TYPE_DATASET, REPO_TYPE_SPACE]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) This would be cleaner with a REPO_TYPE_MODEL eventually, no? (can be done later)

Comment on lines -96 to +97
token=self._token, name=REPO_NAME, repo_type=REPO_TYPE_DATASET
token=self._token, name=DATASET_REPO_NAME, repo_type=REPO_TYPE_DATASET
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@julien-c julien-c merged commit 8cb5df4 into main Jun 15, 2021
@julien-c julien-c deleted the spaces_support branch June 15, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants