Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect NO_COLOR env var #1103

Merged
merged 2 commits into from
Oct 10, 2022
Merged

respect NO_COLOR env var #1103

merged 2 commits into from
Oct 10, 2022

Conversation

singingwolfboy
Copy link
Contributor

Alternative to #1100. Makes huggingface-cli compliant with https://no-color.org.

Wauplin
Wauplin approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation and testing @singingwolfboy !
I'll merge the PR as soon as the CI is green.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 10, 2022 •
edited

The documentation is not available anymore as the PR was closed or merged.

@osanseviero
Copy link
Member

Thanks for the contribution!

@Wauplin Wauplin merged commit 2b2823e into huggingface:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wauplin Wauplin Wauplin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@singingwolfboy @HuggingFaceDocBuilderDev @osanseviero @Wauplin