Fix test test_list_models_search
#1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
requested review from
LysandreJik and
osanseviero
and removed request for
LysandreJik
|
The documentation is not available anymore as the PR was closed or merged. |
osanseviero
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is not ideal anyway as we are more testing the Hub behavior than
huggingface_hubbut I guess it is still a good test to keep for now. Hub search rules have recently changed to include more than the model id. Previous implementation of the test was checking that all returned models containedbertin there name which is not necesarly the case anymore.A ok-ish solution is to test only the first 10 models that are returned and assume the search is not completely broken if it works for those ones :)