Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust create relative symlink in cache #1109

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Oct 12, 2022

Should fix #1108.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 12, 2022

The documentation is not available anymore as the PR was closed or merged.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 57.23% // Head: 84.91% // Increases project coverage by +27.68% 🎉

Coverage data is based on head (494c417) compared to base (6415cd1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1109       +/-   ##
===========================================
+ Coverage   57.23%   84.91%   +27.68%     
===========================================
  Files          38       38               
  Lines        3926     3931        +5     
===========================================
+ Hits         2247     3338     +1091     
+ Misses       1679      593     -1086     
Impacted Files Coverage Δ
src/huggingface_hub/file_download.py 87.57% <100.00%> (+27.64%) ⬆️
src/huggingface_hub/repository.py 79.72% <0.00%> (+0.86%) ⬆️
src/huggingface_hub/_commit_api.py 92.10% <0.00%> (+3.50%) ⬆️
src/huggingface_hub/utils/_subprocess.py 100.00% <0.00%> (+11.11%) ⬆️
src/huggingface_hub/utils/_hf_folder.py 100.00% <0.00%> (+11.53%) ⬆️
src/huggingface_hub/utils/_deprecation.py 100.00% <0.00%> (+12.28%) ⬆️
src/huggingface_hub/commands/user.py 33.75% <0.00%> (+12.50%) ⬆️
src/huggingface_hub/utils/_validators.py 100.00% <0.00%> (+17.24%) ⬆️
src/huggingface_hub/community.py 91.35% <0.00%> (+17.28%) ⬆️
src/huggingface_hub/utils/_headers.py 100.00% <0.00%> (+18.00%) ⬆️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing!

src/huggingface_hub/file_download.py Outdated Show resolved Hide resolved
src/huggingface_hub/file_download.py Outdated Show resolved Hide resolved
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@Wauplin Wauplin merged commit 4bd9ebf into main Oct 12, 2022
@Wauplin Wauplin deleted the 1108-robust-create-symlink branch October 12, 2022 13:20
@Wauplin
Copy link
Contributor Author

Wauplin commented Oct 12, 2022

Cool, thanks for reviewing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky error "File already exist" during symlink creation
3 participants