Add windows machine for CI #1112
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Codecov ReportBase: 55.97% // Head: 83.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
===========================================
+ Coverage 55.97% 83.58% +27.60%
===========================================
Files 47 47
Lines 4700 4703 +3
===========================================
+ Hits 2631 3931 +1300
+ Misses 2069 772 -1297
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Ok great! Thanks a lot for working on this super important PR @Wauplin.
Very reassuring to see that the majority of the changes had to take place within the testing code rather than within the library code.
docs/source/installation.mdx
Outdated
| - `huggingface_hub`'s cache system relies on symlinks to efficiently cache files downloaded | ||
| from the Hub. On Windows, you must activate developer mode or run your script as admin to | ||
| enable symlinks. Please read [this page](./how-to-cache#limitations) for more details. |
There was a problem hiding this comment.
Maybe mention here that if this isn't activated, it will still work, just in a non-optimized manner
| @@ -127,7 +128,9 @@ def save(self, filepath: Union[Path, str]): | |||
| """ | |||
| filepath = Path(filepath) | |||
| filepath.parent.mkdir(parents=True, exist_ok=True) | |||
| filepath.write_text(str(self), encoding="utf-8") | |||
There was a problem hiding this comment.
Interesting, this didn't work as expected on Windows?
There was a problem hiding this comment.
It was "working" but encoding a newline was different on Windows ("\n\r") than Linux/Macos ("\n"). That's what the newline="" is for otherwise you get a big diff if you edit a README file from different platforms. And pathlib.Path.write_text doesn't have this parameter in Python 3.7 so I had to use the standard open(...).
(And yes, I discovered/learnt about all this while working on this PR :D)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Fix #1074.
PR is finally green !! ✔️ ✔️ ✔️ 😄
It includes:
build-windows: runs "only" normal tests (no TF/torch/LFS-specific stuff). Not so optimized so it takes 20 mins to run 😕 Could be improved to run Repository and non-repo tests separately. Only run on Python3.7 as I would expect the Python3.11 to be already fully tested on Ubuntu.Repocardmodule, especially for"\n"vs"\r\n"stuffand I think that's mostly it :)
TODO:
pending_questions.mdfile\rin it)