Replace use_auth_token arg by token everywhere
#1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Codecov ReportBase: 84.46% // Head: 84.54% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
+ Coverage 84.46% 84.54% +0.08%
==========================================
Files 41 41
Lines 4074 4089 +15
==========================================
+ Hits 3441 3457 +16
+ Misses 633 632 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Wauplin
commented
Oct 21, 2022
Wauplin
changed the title
use_auth_token arg by token everywhereuse_auth_token arg by token everywhere
adrinjalali
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1094 (see discussion there).
This is step 1 on the long-term plan to have a single
tokenargument (eitherOptional[str]orOptional[Union[bool, str]]) instead of eithertokenoruse_auth_tokendepending on the use case. Sinceuse_auth_tokenis still widely used, we are only smoothly deprecating it by accepting it without warning while havingtokenas the preferred (and documented) argument. After a few months and adaptations in downstream libraries, we will start a proper deprecation cycle foruse_auth_token. At the moment, all the magic is implemented invalidate_hf_hub_args. I hope this will not be too misleading for users.I have written the step by step plan in the
smoothly_deprecate_use_auth_tokenmethod. I would be good to have a look at the generated documentation so that we are all aligned.This should finally be the last piece of work on tokens in
hugginface_hubafter #1064 (always send token when logged in), #1084 (send token on LFS upload), #1111 (unifiedlogin()method) and #1116 (add token toHfApi(token=...). Hope that authentication will now be as smooth as possible for all users. (EDIT: I forgot #1051 about git credential store to change...).cc @adrinjalali @lhoestq @sgugger @julien-c @LysandreJik @osanseviero who contributed to the discussion on this topic.